Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 137143010: New analyzer snapshot. (Closed)

Created:
6 years, 11 months ago by scheglov
Modified:
6 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New analyzer snapshot. There are some problems with JDT and line comments. Interesting, that it works almost everywhere, and also worked coupld weeks ago. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32052

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3251 lines, -1153 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolver.java View 7 chunks +11 lines, -11 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_engine.dart View 2 chunks +117 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 4 chunks +41 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineSemanticProcessor.java View 1 chunk +17 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 7 chunks +32 lines, -37 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 4 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 19 chunks +123 lines, -106 lines 1 comment Download
M pkg/analyzer/lib/src/generated/engine.dart View 80 chunks +1609 lines, -253 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 13 chunks +56 lines, -45 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 4 chunks +6 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 24 chunks +67 lines, -37 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_engine.dart View 2 chunks +117 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 145 chunks +280 lines, -271 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 70 chunks +530 lines, -355 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 7 chunks +79 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 9 chunks +148 lines, -4 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 11 months ago (2014-01-27 22:16:48 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/137143010/diff/1/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/137143010/diff/1/pkg/analyzer/lib/src/generated/element.dart#newcode5051 pkg/analyzer/lib/src/generated/element.dart:5051: void set hasExtUri2(bool hasExtUri) { For future consideration: ...
6 years, 11 months ago (2014-01-27 22:58:27 UTC) #2
scheglov
6 years, 11 months ago (2014-01-28 04:24:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698