Issue 137123010: Revert "Fix more warnings for dart:html". Appears to be causing dartium failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137123010: Revert "Fix more warnings for dart:html". Appears to be causing dartium failures. (Closed)

Created:
6 years, 10 months ago by Emily Fortuna

Modified:
6 years, 10 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Fix more warnings for dart:html". Appears to be causing dartium failures. BUG= Committed: https://code.google.com/p/dart/source/detail?r=32408

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -144 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	4 chunks	+1 line, -47 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	5 chunks	+2 lines, -48 lines	0 comments	Download
M	sdk/lib/html/html_common/lists.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/analyze_api_test.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/src/CrossFrameTypes.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/src/WrappedEvent.dart	View	2 chunks	+0 lines, -37 lines	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 2 (0 generated)

Emily Fortuna

TBR. Reverting this CL until I can get into the office to test the (possibly ...

6 years, 10 months ago (2014-02-07 07:55:50 UTC) #1

Emily Fortuna

6 years, 10 months ago (2014-02-07 07:56:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r32408 (presubmit successful).