Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1370833003: Extend precompilation test to Mac. Attempt to fix for host MIPS. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extend precompilation test to Mac. Attempt to fix for host MIPS. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/da006acfdfbd6a6eee5faf68b1b5ee0d26f43f06

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -20 lines) Patch
M runtime/bin/extensions_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/precompilation_test.dart View 1 2 2 chunks +43 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 2 months ago (2015-09-25 23:37:53 UTC) #2
Florian Schneider
lgtm
5 years, 2 months ago (2015-09-28 09:05:10 UTC) #3
rmacnak
5 years, 2 months ago (2015-09-28 17:04:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
da006acfdfbd6a6eee5faf68b1b5ee0d26f43f06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698