Issue 1370793003: Issue 24442. Fix for renaming library names with spaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1370793003: Issue 24442. Fix for renaming library names with spaces. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
	M	pkg/analysis_server/lib/src/services/correction/source_range.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/analysis_server/test/services/refactoring/rename_library_test.dart	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Brian Wilkerson

LGTM Are we going to clean up other uses of "element.displayName.length"?

5 years, 2 months ago (2015-09-25 20:52:02 UTC) #2

scheglov

Yes, we are. It didn't cause problems anywhere else, but it's still worth to do.

5 years, 2 months ago (2015-09-25 20:53:27 UTC) #3

scheglov

5 years, 2 months ago (2015-09-25 20:55:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4f8649f1b32f8b2f8a60b03f9b5d70cde38c7a3a (presubmit successful).