Issue 13704003: Reapply "Add a sleep function to dart:io"

Issue 13704003: Reapply "Add a sleep function to dart:io" (Closed)

Created:
7 years, 8 months ago by Søren Gjesse

Modified:
7 years, 8 months ago

Reviewers:
Bob Nystrom, Mads Ager (google)

CC:
reviews_dartlang.org, Bob Nystrom, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Add a sleep function to dart:io" This reapplies r20952, r20953, r20954 together with hiding sleep from dart:io in a number of tests. R=ager@google.com Committed: https://code.google.com/p/dart/source/detail?r=20964

Patch Set 1 #

Patch Set 2 : Added "hide sleep" where needed #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -30 lines)			Patch
M	pkg/scheduled_test/test/scheduled_test/current_schedule_errors_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/test/scheduled_test/nested_task_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/test/scheduled_test/out_of_band_task_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/test/scheduled_test/signal_error_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/test/scheduled_test/task_return_value_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/test/scheduled_test/timeout_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/test/scheduled_test/wrap_async_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/test/scheduled_test/wrap_future_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/io_natives.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/process.cc	View		3 chunks	+11 lines, -2 lines	0 comments	Download
M	runtime/bin/process_patch.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/bin/utils.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/utils_android.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/bin/utils_linux.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/bin/utils_macos.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/bin/utils_win.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/io_patch.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/io/process.dart	View		3 chunks	+12 lines, -1 line	0 comments	Download
A +	tests/standalone/io/sleep_test.dart	View		1 chunk	+11 lines, -3 lines	2 comments	Download
M	utils/pub/command_cache.dart	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	utils/pub/sdk.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #2 manually as r20964 (presubmit successful).

7 years, 8 months ago (2013-04-05 13:04:51 UTC) #3

Bob Nystrom

pkg/ and pub changes LGTM! https://codereview.chromium.org/13704003/diff/2001/tests/standalone/io/sleep_test.dart File tests/standalone/io/sleep_test.dart (right): https://codereview.chromium.org/13704003/diff/2001/tests/standalone/io/sleep_test.dart#newcode10 tests/standalone/io/sleep_test.dart:10: sleep(new Duration(milliseconds: milliseconds)); How ...

7 years, 8 months ago (2013-04-05 15:51:57 UTC) #4

Søren Gjesse

7 years, 8 months ago (2013-04-08 08:05:59 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/13704003/diff/2001/tests/standalone/io/sleep_...
File tests/standalone/io/sleep_test.dart (right):

https://codereview.chromium.org/13704003/diff/2001/tests/standalone/io/sleep_...
tests/standalone/io/sleep_test.dart:10: sleep(new Duration(milliseconds:
milliseconds));
On 2013/04/05 15:51:57, Bob Nystrom wrote:
> How about a test for passing a zero duration? Negative?

Good point. See https://codereview.chromium.org/13497008/.

Expand Messages | Collapse Messages