Fix computation of errors to not run extra tasks

Fix computation of errors to not run extra tasks

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0f30af628a87dd091f880eb176492009f7a3e081

[scheglov, 2015-09-29 21:55:32]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-09-29 21:55:33]

LGTM

Couple tests would be nice.

https://codereview.chromium.org/1370323003/diff/1/pkg/analyzer/lib/src/task/i...
File pkg/analyzer/lib/src/task/inputs.dart (right):

https://codereview.chromium.org/1370323003/diff/1/pkg/analyzer/lib/src/task/i...
pkg/analyzer/lib/src/task/inputs.dart:735: return true;
Too bad that we have to duplicate logic here :-(

[Brian Wilkerson, 2015-09-29 22:11:00]

https://codereview.chromium.org/1370323003/diff/1/pkg/analyzer/lib/src/task/i...
File pkg/analyzer/lib/src/task/inputs.dart (right):

https://codereview.chromium.org/1370323003/diff/1/pkg/analyzer/lib/src/task/i...
pkg/analyzer/lib/src/task/inputs.dart:735: return true;
Agreed. I couldn't think of a good way to restructure the code to avoid it, but
I'll look again. Meanwhile, I'll add some tests.

[Brian Wilkerson, 2015-09-30 18:31:14]

I still didn't come up with a better way to structure the code, but I did get
tests added. PTAL.

[scheglov, 2015-09-30 18:46:50]

On 2015/09/30 18:31:14, Brian Wilkerson wrote:
> I still didn't come up with a better way to structure the code, but I did get
> tests added. PTAL.

LGTM

[Brian Wilkerson, 2015-09-30 18:55:22]

Committed patchset #2 (id:20001) manually as
0f30af628a87dd091f880eb176492009f7a3e081 (presubmit successful).