setUp/tearDown may be called repeatedly in a group.

setUp/tearDown may be called repeatedly in a group.

Closes #313

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/0188985ec9804d7cb8fc708ebd374b796a5e5bba

[kevmoo, 2015-09-24 21:33:29]

LGTM, but...

What's the behavior if one intermingles

test()
setUp()
test()
tearDown()
setUp()

I could imagine folks would expect that calls to setup after the first test
wouldn't apply, etc.

https://codereview.chromium.org/1369613002/diff/1/lib/src/backend/group.dart
File lib/src/backend/group.dart (right):

https://codereview.chromium.org/1369613002/diff/1/lib/src/backend/group.dart#...
lib/src/backend/group.dart:9: import '../../test.dart';
unused import?

[kevmoo, 2015-09-24 21:34:10]

Also

This closes https://github.com/dart-lang/test/issues/313

[nweiz, 2015-09-24 22:23:54]

Code review changes

[nweiz, 2015-09-24 22:25:48]

I don't think people really try to intermingle scaffolding with tests in
practice; the behavior for that has always been hoisting it to the top, and I
don't think this'll change that.

https://codereview.chromium.org/1369613002/diff/1/lib/src/backend/group.dart
File lib/src/backend/group.dart (right):

https://codereview.chromium.org/1369613002/diff/1/lib/src/backend/group.dart#...
lib/src/backend/group.dart:9: import '../../test.dart';
On 2015/09/24 21:33:29, kevmoo wrote:
> unused import?

Done.

[nweiz, 2015-09-24 22:25:58]

Committed patchset #2 (id:20001) manually as
0188985ec9804d7cb8fc708ebd374b796a5e5bba (presubmit successful).