Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 136953005: Fix html/js test on Dartium. (Closed)

Created:
6 years, 10 months ago by Vyacheslav Egorov (Chromium)
Modified:
6 years, 10 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix html/js test on Dartium. Don't use identity check on strings, use equality instead. R=kasperl@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/html/js_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
6 years, 10 months ago (2014-02-03 13:47:59 UTC) #1
kasperl
LGTM.
6 years, 10 months ago (2014-02-03 13:48:56 UTC) #2
Vyacheslav Egorov (Chromium)
6 years, 10 months ago (2014-02-03 13:52:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32245 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698