Issue 136923004: Ensure that MaterializeObject has relaxed RequiredInputRepresentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136923004: Ensure that MaterializeObject has relaxed RequiredInputRepresentation. (Closed)

Created:
6 years, 11 months ago by Vyacheslav Egorov (Chromium)

Modified:
6 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google), Florian Schneider, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ensure that MaterializeObject has relaxed RequiredInputRepresentation. Instruction itself is essentially a part of a deoptimization enviroment and thus can deal with any representation. Default RequiredInputRepresentation is too strict and require tagged representation for all inputs which leads to ineffecient code: SelectRepresentations pass which is run while materializations are still in the graph will insert redundant boxing. R=srdjan@google.com BUG=dart:16063 Committed: https://code.google.com/p/dart/source/detail?r=31753

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	runtime/vm/intermediate_language.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

6 years, 11 months ago (2014-01-13 19:33:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r31753 (presubmit successful).

Expand Messages | Collapse Messages