Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1369033002: Completions with exact prefix should be prioritized - fixes #23099 (Closed)

Created:
5 years, 2 months ago by danrubel
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Completions with exact prefix should be prioritized - fixes #23099 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/04e21a2a7c38a0b944e46671271503a07c9e2954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 2 months ago (2015-09-25 20:32:30 UTC) #2
scheglov
lgtm
5 years, 2 months ago (2015-09-25 20:40:43 UTC) #3
danrubel
5 years, 2 months ago (2015-10-02 19:12:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04e21a2a7c38a0b944e46671271503a07c9e2954 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698