Issue 1368963002: dart2js cps: Logical rewriter should treat Throw as a terminator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1368963002: dart2js cps: Logical rewriter should treat Throw as a terminator. (Closed)

Created:
5 years, 2 months ago by asgerf

Modified:
5 years, 2 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Logical rewriter should treat Throw as a terminator. Because of this bug, the tree IR had a tendency to put throw statements at the bottom of a method, even if it meant inserting an explicit negation in a branch. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/3cd331cbb66add2c564439a4e604872f073d4946

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

asgerf

5 years, 2 months ago (2015-09-28 09:14:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3cd331cbb66add2c564439a4e604872f073d4946 (presubmit successful).