Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1368793003: The 'analysis.implemented' notification implementation. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

The 'analysis.implemented' notification implementation. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/df827a06aed1f3dcd015158f5864b2c33d163732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -17 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 6 chunks +50 lines, -17 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart View 1 chunk +73 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 2 chunks +22 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/analysis/notification_implemented_test.dart View 1 chunk +289 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-09-25 18:52:34 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-09-25 19:25:19 UTC) #2
scheglov
5 years, 2 months ago (2015-09-25 19:33:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df827a06aed1f3dcd015158f5864b2c33d163732 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698