Issue 1368793002: Add OSThread::GetCurrentThreadTraceId and use it in the timeline implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1368793002: Add OSThread::GetCurrentThreadTraceId and use it in the timeline implementation (Closed)

Created:
5 years, 3 months ago by Cutch

Modified:
5 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add OSThread::GetCurrentThreadTraceId and use it in the timeline implementation - This ensures our trace-event thread ids match the thread ids used in Chromium's base. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8685d2ebf596494366cfb37e4a30f0822a11460a

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
M	runtime/vm/os_thread.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/os_thread_android.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/os_thread_linux.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/os_thread_macos.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/os_thread_win.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/timeline.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Cutch

5 years, 3 months ago (2015-09-24 21:57:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8685d2ebf596494366cfb37e4a30f0822a11460a (presubmit successful).