Issue 1368773002: Modify String::IdentifierPrettyName to work with zone allocated temporary strings instead of String…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1368773002: Modify String::IdentifierPrettyName to work with zone allocated temporary strings instead of String… (Closed)

Created:
5 years, 3 months ago by srdjan

Modified:
5 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Modify String::IdentifierPrettyName to work with zone allocated temporary strings instead of String heap objects. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/1ffada9e9848cf765f4ea58b2f59e1078916c6eb

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -30 lines)			Patch
	M	runtime/vm/object.cc	View		6 chunks	+73 lines, -30 lines	0 comments	Download
	M	runtime/vm/object_test.cc	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

srdjan

5 years, 3 months ago (2015-09-24 22:00:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1ffada9e9848cf765f4ea58b2f59e1078916c6eb (presubmit successful).