Issue 136863003: Line breaking plumbing (continued).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136863003: Line breaking plumbing (continued). (Closed)

Created:
6 years, 11 months ago by pquitslund

Modified:
6 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Line breaking plumbing (continued). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=31751

Patch Set 2 : #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -8 lines)			Patch
M	pkg/analyzer/lib/src/services/formatter_impl.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/services/writer.dart	View		7 chunks	+26 lines, -6 lines	1 comment	Download
M	pkg/analyzer/test/services/formatter_test.dart	View	1	3 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pquitslund

https://codereview.chromium.org/136863003/diff/30001/pkg/analyzer/lib/src/services/writer.dart File pkg/analyzer/lib/src/services/writer.dart (right): https://codereview.chromium.org/136863003/diff/30001/pkg/analyzer/lib/src/services/writer.dart#newcode130 pkg/analyzer/lib/src/services/writer.dart:130: bool isWhitespace(Chunk chunk) { This *can't* be the best ...

6 years, 11 months ago (2014-01-13 16:39:55 UTC) #1

pquitslund

6 years, 11 months ago (2014-01-13 18:20:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31751 (presubmit successful).

Expand Messages | Collapse Messages

Issue 136863003: Line breaking plumbing (continued). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages