Issue 13686006: Add extra Path test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13686006: Add extra Path test. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen

Modified:
7 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add extra Path test. BUG=https://code.google.com/p/dart/issues/detail?id=4861 Committed: https://code.google.com/p/dart/source/detail?r=21076

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/standalone/io/path_test.dart	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm with comments https://codereview.chromium.org/13686006/diff/1/tests/standalone/io/path_test.dart File tests/standalone/io/path_test.dart (right): https://codereview.chromium.org/13686006/diff/1/tests/standalone/io/path_test.dart#newcode326 tests/standalone/io/path_test.dart:326: var c4Path = new Path(r'C:\'); Shouldn't ...

7 years, 8 months ago (2013-04-08 14:54:16 UTC) #2

Anders Johnsen

Ty, landing. https://codereview.chromium.org/13686006/diff/1/tests/standalone/io/path_test.dart File tests/standalone/io/path_test.dart (right): https://codereview.chromium.org/13686006/diff/1/tests/standalone/io/path_test.dart#newcode326 tests/standalone/io/path_test.dart:326: var c4Path = new Path(r'C:\'); On 2013/04/08 ...

7 years, 8 months ago (2013-04-08 14:55:58 UTC) #3

Anders Johnsen

7 years, 8 months ago (2013-04-08 14:56:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21076 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13686006: Add extra Path test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages