Issue 13686005: WebSocket: Correctly expect masked frames from clients, and send masked frames from the client.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13686005: WebSocket: Correctly expect masked frames from clients, and send masked frames from the client. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen

Modified:
7 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

WebSocket: Correctly expect masked frames from clients, and send masked frames from the client. BUG=https://code.google.com/p/dart/issues/detail?id=9723 Committed: https://code.google.com/p/dart/source/detail?r=21075

Patch Set 1 #

Patch Set 2 : Simplify code. #

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -21 lines)			Patch
M	runtime/bin/common_patch.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
D	runtime/bin/http_patch.dart	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	runtime/bin/io_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/io_patch.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/io/common.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/io/http_session.dart	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	sdk/lib/io/websocket_impl.dart	View	1	7 chunks	+28 lines, -5 lines	0 comments	Download
M	tests/standalone/io/web_socket_protocol_processor_test.dart	View	1 2	2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

On 2013/04/08 14:06:30, Anders Johnsen wrote: Added bug

7 years, 8 months ago (2013-04-08 14:06:47 UTC) #2

Søren Gjesse

LGTM Should we add a test where a client sends an unmasked frame? Would need ...

7 years, 8 months ago (2013-04-08 14:13:48 UTC) #3

Anders Johnsen

7 years, 8 months ago (2013-04-08 14:36:02 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r21075 (presubmit successful).

Expand Messages | Collapse Messages