Issue 13685022: Make mixins work on native classes.

Issue 13685022: Make mixins work on native classes. (Closed)

Created:
7 years, 8 months ago by sra1

Modified:
7 years, 8 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make mixins work on native classes. Committed: https://code.google.com/p/dart/source/detail?r=21104

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -77 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	5 chunks	+32 lines, -16 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	6 chunks	+1 line, -57 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js_native/dart2js_native.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
A	tests/compiler/dart2js_native/native_mixin_with_plain_test.dart	View		1 chunk	+105 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM! https://codereview.chromium.org/13685022/diff/7001/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/13685022/diff/7001/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode967 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:967: assert(classElement.isMixinApplication); This assert doesn't really by us much. ...

7 years, 8 months ago (2013-04-08 11:44:08 UTC) #2

sra1

Committed patchset #2 manually as r21104 (presubmit successful).

7 years, 8 months ago (2013-04-08 19:29:06 UTC) #3

sra1

7 years, 8 months ago (2013-04-08 19:30:11 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/13685022/diff/7001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/13685022/diff/7001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:967:
assert(classElement.isMixinApplication);
On 2013/04/08 11:44:09, kasperl wrote:
> This assert doesn't really by us much. Assertions are enabled exactly when
type
> checks are enabled so this is covered by the next line.

Done.

https://codereview.chromium.org/13685022/diff/7001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:969: print('\n
 $member'
On 2013/04/08 11:44:09, kasperl wrote:
> Remove debug printing.

Done.

https://codereview.chromium.org/13685022/diff/7001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/13685022/diff/7001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1173: //
TODO(kasperl): We should make sure to only emit one version of
On 2013/04/08 11:44:09, kasperl wrote:
> Is this comment still valid?

Done.

Expand Messages | Collapse Messages