Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 13685021: Properly exposing NodeIterator and TreeWalker. (Closed)

Created:
7 years, 8 months ago by blois
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly exposing NodeIterator and TreeWalker Also removing references to EntityReference which is an outdated XML type. Note that there's a bit of an oddity here around NodeFilter, which is both a class with all of the filter flags, and a function signature for a callback. For now, I've scrubbed references to NodeFilter (the callback), but if desired I can add a new filter callback. This will most likely require a bit of Dartium work as well, so a separate CL I think. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=22160

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -69 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 8 chunks +29 lines, -25 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +29 lines, -33 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/html/node_test.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 4 chunks +6 lines, -3 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_NodeIterator.darttemplate View 1 chunk +3 lines, -4 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_TreeWalker.darttemplate View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jennifer Messerly
lgtm. Funny that the types already existed, they just weren't constructable.
7 years, 8 months ago (2013-04-09 02:22:40 UTC) #1
blois
7 years, 7 months ago (2013-04-30 01:36:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r22160 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698