Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 13685004: Reduce usage of ItearbleMixinWorkaround. (Closed)

Created:
7 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reduce usage of IterableMixinWorkaround. Committed: https://code.google.com/p/dart/source/detail?r=20969

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. Move more into _HashSetBase. Fix bug in min-max test #

Patch Set 3 : Addressed review comments. #

Patch Set 4 : Fix bug in set-base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -132 lines) Patch
M pkg/serialization/lib/src/serialization_rule.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/DataSource.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M samples/swarm/swarm_ui_lib/observable/observable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/hash_set.dart View 1 2 3 3 chunks +59 lines, -31 lines 0 comments Download
M sdk/lib/collection/linked_hash_set.dart View 1 2 5 chunks +35 lines, -69 lines 0 comments Download
M sdk/lib/collection/queue.dart View 2 chunks +22 lines, -13 lines 0 comments Download
M tests/corelib/iterable_min_max_test.dart View 1 3 chunks +0 lines, -11 lines 0 comments Download
M tools/dom/src/WrappedList.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 8 months ago (2013-04-05 12:30:41 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/13685004/diff/1/sdk/lib/collection/hash_set.dart File sdk/lib/collection/hash_set.dart (right): https://codereview.chromium.org/13685004/diff/1/sdk/lib/collection/hash_set.dart#newcode7 sdk/lib/collection/hash_set.dart:7: class HashSet<E> extends Collection<E> with _SetMixin<E> implements Set<E> ...
7 years, 8 months ago (2013-04-05 12:38:17 UTC) #2
Lasse Reichstein Nielsen
7 years, 8 months ago (2013-04-05 15:01:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r20969 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698