pkg/intl test cleanup

pkg/intl test cleanup

pkg/unittest has evolved a lot. Helping intl use some of the new features and
avoid some problems. I think I fixed some issues in the process

BUG=https://code.google.com/p/dart/issues/detail?id=9342

Committed: https://code.google.com/p/dart/source/detail?r=20993

[kevmoo-old, 2013-04-05 00:35:16]

This started as more of my crazy cleanup of unittest.

There was some funky async magic happening that I think I've cleaned up.

Also, I think I took care of Issue 9342 in the process.

PTAL

[kevmoo-old, 2013-04-05 00:45:42]

Notes

https://codereview.chromium.org/13684003/diff/1/pkg/intl/test/date_time_forma...
File pkg/intl/test/date_time_format_test_core.dart (left):

https://codereview.chromium.org/13684003/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_core.dart:247: var locales = subset == null
? allLocales() : subset;
subset is never null, so removing this logic

https://codereview.chromium.org/13684003/diff/1/pkg/intl/test/date_time_forma...
File pkg/intl/test/date_time_format_test_core.dart (right):

https://codereview.chromium.org/13684003/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_core.dart:188: void runDateTests(Function
subsetFunc) {
Passing in a function that is not called until a test is run.

By the time tests are run, async init has happened and the function call
succeeds.

https://codereview.chromium.org/13684003/diff/1/pkg/intl/test/date_time_forma...
File pkg/intl/test/date_time_format_test_stub.dart (right):

https://codereview.chromium.org/13684003/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_stub.dart:46: void runWith(TestListFunc
getSubset, String dir,
Unify all of the 'runWith' logic across local, file, http

Defines the correct async init logic once

https://codereview.chromium.org/13684003/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_test_stub.dart:54: setUp(() {
Instead of creating more tests within a running test (something I'm going to
make illegal) use the newish async setUp logic in unittest

https://codereview.chromium.org/13684003/diff/1/pkg/intl/test/date_time_forma...
File pkg/intl/test/date_time_format_uninitialized_test.dart (right):

https://codereview.chromium.org/13684003/diff/1/pkg/intl/test/date_time_forma...
pkg/intl/test/date_time_format_uninitialized_test.dart:14: runDateTests(() =>
['en_US']);
In the new world, a func is passed in to allow async init to happen before tests
request values.

In this case, the request is pretty straight-forward.

https://codereview.chromium.org/13684003/diff/1/pkg/pkg.status
File pkg/pkg.status (left):

https://codereview.chromium.org/13684003/diff/1/pkg/pkg.status#oldcode23
pkg/pkg.status:23: [$compiler == none && $runtime == vm]
new async logic addresses this...I think.

https://codereview.chromium.org/13684003/diff/1/pkg/pkg.status#oldcode93
pkg/pkg.status:93: # Skip http request tests on Dartium while resolving an odd
I think using the correct async init logic resolves this.

[Emily Fortuna, 2013-04-05 16:31:28]

lgtm! But wait to hear back from Alan first. This test code is all his, so he's
more familiar with it.

[Alan Knight, 2013-04-05 17:29:05]

Lovely, thanks. LGTM.

Sadly, I'm hoping to delete a lot of this code soon anyway.  Now that we have
lazy loading more or less available I think the mechanisms for loading locale
information from files or over XHR can go away in favor of that.

[kevmoo-old, 2013-04-05 18:24:26]

Committed patchset #2 manually as r20993 (presubmit successful).