Issue 13680002: StreamConsumer has an addStream and a close functions.

Issue 13680002: StreamConsumer has an addStream and a close functions. (Closed)

Created:
7 years, 8 months ago by floitsch

Modified:
7 years, 8 months ago

Reviewers:
Søren Gjesse, Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, Anders Johnsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

StreamConsumer has an addStream and a close functions. The 'consume' function will be removed. Committed: https://code.google.com/p/dart/source/detail?r=20979

Patch Set 2 : Update comments. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -20 lines)			Patch
M	pkg/http/test/safe_http_server.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	sdk/lib/async/stream.dart	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View		4 chunks	+10 lines, -9 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	1	5 chunks	+28 lines, -4 lines	0 comments	Download
M	sdk/lib/io/http_parser.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/io/io_sink.dart	View	1	2 chunks	+16 lines, -2 lines	0 comments	Download
M	tests/lib/async/slow_consumer2_test.dart	View		2 chunks	+13 lines, -1 line	0 comments	Download
M	tests/lib/async/slow_consumer3_test.dart	View		2 chunks	+13 lines, -1 line	0 comments	Download
M	tests/lib/async/slow_consumer_test.dart	View		2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

First steps towards migrating StreamConsumer towards having an addStream and a close.

7 years, 8 months ago (2013-04-04 23:53:36 UTC) #1

Søren Gjesse

lgtm https://codereview.chromium.org/13680002/diff/1/sdk/lib/io/io_sink.dart File sdk/lib/io/io_sink.dart (right): https://codereview.chromium.org/13680002/diff/1/sdk/lib/io/io_sink.dart#newcode47 sdk/lib/io/io_sink.dart:47: Future<T> writeStream(Stream<List<int>> stream); The plan is then to ...

7 years, 8 months ago (2013-04-05 05:23:18 UTC) #2

floitsch

https://codereview.chromium.org/13680002/diff/1/sdk/lib/io/io_sink.dart File sdk/lib/io/io_sink.dart (right): https://codereview.chromium.org/13680002/diff/1/sdk/lib/io/io_sink.dart#newcode47 sdk/lib/io/io_sink.dart:47: Future<T> writeStream(Stream<List<int>> stream); On 2013/04/05 05:23:19, Søren Gjesse wrote: ...

7 years, 8 months ago (2013-04-05 16:21:32 UTC) #3

floitsch

7 years, 8 months ago (2013-04-05 16:22:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20979 (presubmit successful).

Expand Messages | Collapse Messages