Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1367723003: ErrorHandler typedef fix. (Closed)

Created:
5 years, 3 months ago by pquitslund
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

ErrorHandler typedef fix. Lo and behold this harkens back to lint request #1 (https://github.com/dart-lang/linter/issues/1). Could have saved me a headache! R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/72ee80467a7a7680f9188144f3a03c747225b12d

Patch Set 1 #

Patch Set 2 : version bump #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M pkg/analyzer/CHANGELOG.md View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/plugin_configuration.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 3 months ago (2015-09-23 21:30:37 UTC) #2
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-23 21:36:15 UTC) #3
pquitslund
5 years, 3 months ago (2015-09-23 21:39:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
72ee80467a7a7680f9188144f3a03c747225b12d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698