Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1367433002: Avoid warning when using `return;` from sync* and async* functions. (Closed)

Created:
5 years, 3 months ago by sigurdm
Modified:
5 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : add unittest #

Patch Set 4 : Fix mock_libraries modification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/async_return_types_test.dart View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
sigurdm
5 years, 3 months ago (2015-09-23 08:04:38 UTC) #2
Johnni Winther
LGTM but also add a test to the type_checker_test.dart unittest.
5 years, 3 months ago (2015-09-23 08:08:23 UTC) #3
sigurdm
ptal
5 years, 3 months ago (2015-09-23 08:34:57 UTC) #6
Johnni Winther
lgtm
5 years, 3 months ago (2015-09-23 09:00:43 UTC) #7
sigurdm
Committed patchset #3 (id:80001) manually as 75f80a204b98ebd65a5da1f2c1db6c6388d67887 (presubmit successful).
5 years, 3 months ago (2015-09-23 09:07:43 UTC) #8
sigurdm
ptal
5 years, 3 months ago (2015-09-23 10:43:30 UTC) #9
Johnni Winther
lgtm
5 years, 3 months ago (2015-09-23 11:09:46 UTC) #10
sigurdm
5 years, 3 months ago (2015-09-23 11:51:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:100001) manually as
1c3dd67408df7273d7b71915569ab8a7ef2a67aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698