Issue 13674024: Normalize packages' library names.

Issue 13674024: Normalize packages' library names. (Closed)

Created:
7 years, 8 months ago by nweiz

Modified:
7 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Normalize packages' library names. This makes the library names play nicer with dartdoc. Committed: https://code.google.com/p/dart/source/detail?r=21106

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -13 lines)			Patch
M	pkg/http/lib/http.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/http/lib/testing.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	pkg/oauth2/lib/src/client.dart	View	1 chunk	+1 line, -1 line	2 comments	Download
M	pkg/scheduled_test/lib/descriptor.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/lib/scheduled_process.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/lib/scheduled_server.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/lib/src/descriptor/descriptor.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
	pkg/scheduled_test/lib/src/descriptor/nothing_descriptor.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/stack_trace/lib/stack_trace.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One nit but LGTM. https://codereview.chromium.org/13674024/diff/1/pkg/oauth2/lib/src/client.dart File pkg/oauth2/lib/src/client.dart (right): https://codereview.chromium.org/13674024/diff/1/pkg/oauth2/lib/src/client.dart#newcode5 pkg/oauth2/lib/src/client.dart:5: library oauth2_client; Not oauth2.client?

7 years, 8 months ago (2013-04-05 23:49:14 UTC) #2

nweiz

https://codereview.chromium.org/13674024/diff/1/pkg/oauth2/lib/src/client.dart File pkg/oauth2/lib/src/client.dart (right): https://codereview.chromium.org/13674024/diff/1/pkg/oauth2/lib/src/client.dart#newcode5 pkg/oauth2/lib/src/client.dart:5: library oauth2_client; 2013/04/05 23:49:14, Bob Nystrom wrote: > Not ...

7 years, 8 months ago (2013-04-08 19:32:45 UTC) #3

nweiz

7 years, 8 months ago (2013-04-08 19:39:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21106 (presubmit successful).

Expand Messages | Collapse Messages