Issue 13674014: Catch CalledProcessError which is throw if the command has non-zero exit code.

Issue 13674014: Catch CalledProcessError which is throw if the command has non-zero exit code. (Closed)

Created:
7 years, 8 months ago by ahe

Modified:
7 years, 8 months ago

Reviewers:
floitsch, kustermann

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Catch CalledProcessError which is throw if the command has non-zero exit code. Committed: https://code.google.com/p/dart/source/detail?r=20992

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	dart/tools/build.py	View		1 chunk	+7 lines, -3 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ahe

Committed patchset #1 manually as r20992 (presubmit successful).

7 years, 8 months ago (2013-04-05 18:15:49 UTC) #4

kustermann

https://codereview.chromium.org/13674014/diff/1/dart/tools/build.py File dart/tools/build.py (right): https://codereview.chromium.org/13674014/diff/1/dart/tools/build.py#newcode271 dart/tools/build.py:271: stderr=subprocess.STDOUT) I don't understand why you added 'stderr=subprocess.STDOUT'. If ...

7 years, 8 months ago (2013-04-06 14:31:04 UTC) #5

ahe

7 years, 8 months ago (2013-04-08 12:46:29 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/13674014/diff/1/dart/tools/build.py
File dart/tools/build.py (right):

https://codereview.chromium.org/13674014/diff/1/dart/tools/build.py#newcode271
dart/tools/build.py:271: stderr=subprocess.STDOUT)
On 2013/04/06 14:31:05, kustermann wrote:
> I don't understand why you added 'stderr=subprocess.STDOUT'.
> If tput outputs something to stderr than we set 'is_fancy_tty = True' -- I
don't
> think this is what we want.

tput is a well-behaved Unix command.  It doesn't print to stderr unless the
return code is non-zero.

But I could probably do something like this:

with open('/dev/null', 'a') as dev_null:
  ... stderr=dev_null

Expand Messages | Collapse Messages