Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1367353003: dart2js cps_ir: Seed type_propagation with constant bools from inference. (Closed)

Created:
5 years, 2 months ago by sra1
Modified:
5 years, 2 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps_ir: Seed type_propagation with constant bools from inference. Global type inference discovers interprocedural constants. Use this information at parameters and invocation return values. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/e04ff2f4f0538475da6351c8a8020ccadbb8e561 Reverted: https://github.com/dart-lang/sdk/commit/45caa197dd8c19536425685f1e201b3ce32bdc77 Committed: https://github.com/dart-lang/sdk/commit/d978e7d45b80a90ff2ffb2c016fd197bd31eef11

Patch Set 1 : #

Patch Set 2 : basis for fixes #

Patch Set 3 : value mask can be nullable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +9 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart View 1 2 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sra1
5 years, 2 months ago (2015-09-29 13:33:27 UTC) #3
asgerf
LGTM
5 years, 2 months ago (2015-09-29 13:36:57 UTC) #4
sra1
Committed patchset #1 (id:20001) manually as e04ff2f4f0538475da6351c8a8020ccadbb8e561 (presubmit successful).
5 years, 2 months ago (2015-09-29 17:08:43 UTC) #5
sra1
5 years, 2 months ago (2015-09-29 22:24:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:50001) manually as
d978e7d45b80a90ff2ffb2c016fd197bd31eef11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698