Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 136713006: Fixing audiobuffersourcenode_test on Chrome (Closed)

Created:
6 years, 11 months ago by blois
Modified:
6 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing audiobuffersourcenode_test on Chrome Issue appears to be that since theres no data that the stream never actually plays, therefore cannot be stopped. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=31754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tests/html/audiobuffersourcenode_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
6 years, 11 months ago (2014-01-13 20:39:30 UTC) #1
Emily Fortuna
lgtm
6 years, 11 months ago (2014-01-13 20:40:04 UTC) #2
blois
6 years, 11 months ago (2014-01-13 20:41:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31754 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698