Issue 13671004: Support UseDartApi vm test on ARM.

Issue 13671004: Support UseDartApi vm test on ARM. (Closed)

Created:
7 years, 8 months ago by regis

Modified:
7 years, 8 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support UseDartApi vm test on ARM. Committed: https://code.google.com/p/dart/source/detail?r=20981

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+619 lines, -34 lines)			Patch
M	runtime/tests/vm/vm.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_arm.h	View	1 2	1 chunk	+2 lines, -8 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 2	3 chunks	+149 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2	8 chunks	+420 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2	1 chunk	+17 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/13671004/diff/10001/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/13671004/diff/10001/runtime/vm/intermediate_language_arm.cc#newcode1081 runtime/vm/intermediate_language_arm.cc:1081: imm = -imm; // TODO(regis): What if deopt ...

7 years, 8 months ago (2013-04-05 16:25:02 UTC) #2

regis

Thanks https://codereview.chromium.org/13671004/diff/10001/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/13671004/diff/10001/runtime/vm/intermediate_language_arm.cc#newcode1081 runtime/vm/intermediate_language_arm.cc:1081: imm = -imm; // TODO(regis): What if deopt ...

7 years, 8 months ago (2013-04-05 16:46:37 UTC) #3

regis

7 years, 8 months ago (2013-04-05 16:47:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r20981 (presubmit successful).

Expand Messages | Collapse Messages