Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1366923003: add performance tests (Closed)

Created:
5 years, 3 months ago by keertip
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : move tests to benchmark #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -2 lines) Patch
A pkg/analysis_server/benchmark/perf/analysis_timing_test.dart View 1 1 chunk +59 lines, -0 lines 0 comments Download
A pkg/analysis_server/benchmark/perf/performance_tests.dart View 1 1 chunk +75 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
keertip
5 years, 3 months ago (2015-09-24 17:42:42 UTC) #2
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-24 19:33:35 UTC) #3
danrubel
[Channeling Kevin here] it's a semi-convention to put performance/benchmark code in the /benchmark dir https://www.dartlang.org/tools/pub/package-layout.html ...
5 years, 3 months ago (2015-09-24 19:49:29 UTC) #4
keertip
On 2015/09/24 19:49:29, danrubel wrote: > [Channeling Kevin here] > it's a semi-convention to put ...
5 years, 2 months ago (2015-09-25 15:29:30 UTC) #5
keertip
5 years, 2 months ago (2015-09-25 15:35:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6f775acc7b21baa15331bd8db2f882a971aa6906 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698