Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1365663002: Tweak navigation for 'part of' directives. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tweak navigation for 'part of' directives. This makes it consistent with import/export/part directives, where only URIs are navigation sources. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5fd8b38737c25d3eadc4ace186e13b7a09904a51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 2 chunks +1 line, -8 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-23 15:32:49 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-23 15:52:14 UTC) #2
scheglov
5 years, 3 months ago (2015-09-23 17:14:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5fd8b38737c25d3eadc4ace186e13b7a09904a51 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698