Issue 13653005: Prevent expensive and unnecessary error formatting in the case a bound check is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13653005: Prevent expensive and unnecessary error formatting in the case a bound check is (Closed)

Created:
7 years, 8 months ago by regis

Modified:
7 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Prevent expensive and unnecessary error formatting in the case a bound check is postponed to run time (issue 9106). Eliminate bound check at compile time in some cases. Fix bound checking of mutually referencing bounds. Added test. Committed: https://code.google.com/p/dart/source/detail?r=20938

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -62 lines)			Patch
M	runtime/vm/class_finalizer.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	9 chunks	+49 lines, -17 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1	7 chunks	+58 lines, -43 lines	0 comments	Download
A	tests/language/f_bounded_quantification3_test.dart	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/13653005/diff/1/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/13653005/diff/1/runtime/vm/object.h#newcode3684 runtime/vm/object.h:3684: bool CheckBound(const AbstractType& bounded_type, Please document what result ...

7 years, 8 months ago (2013-04-04 20:12:52 UTC) #2

regis

Thanks! https://codereview.chromium.org/13653005/diff/1/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/13653005/diff/1/runtime/vm/object.h#newcode3684 runtime/vm/object.h:3684: bool CheckBound(const AbstractType& bounded_type, On 2013/04/04 20:12:52, srdjan ...

7 years, 8 months ago (2013-04-04 20:24:32 UTC) #3

regis

7 years, 8 months ago (2013-04-04 20:24:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20938 (presubmit successful).

Expand Messages | Collapse Messages