Issue 1365183002: Fix MacOS build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1365183002: Fix MacOS build (Closed)

Created:
5 years, 3 months ago by Cutch

Modified:
5 years, 3 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix MacOS build BUG= Committed: https://github.com/dart-lang/sdk/commit/a44db4a0f34344f818e7b6bda60cdea0cb81d3e5

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/os_thread_macos.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #1 (id:1) manually as a44db4a0f34344f818e7b6bda60cdea0cb81d3e5 (presubmit successful).

5 years, 3 months ago (2015-09-24 22:16:09 UTC) #3

Ivan Posva

5 years, 3 months ago (2015-09-25 07:48:42 UTC) #6

Message was sent while issue was closed.

Thanks,
-Ivan

https://codereview.chromium.org/1365183002/diff/1/runtime/vm/os_thread_macos.cc
File runtime/vm/os_thread_macos.cc (right):

https://codereview.chromium.org/1365183002/diff/1/runtime/vm/os_thread_macos....
runtime/vm/os_thread_macos.cc:154: return
ThreadIdFromIntPtr(pthread_mach_thread_np(pthread_self()));
This indicates that ThreadId and TraceId should probably not be the same type.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages