Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1364893004: Run outer tearDown()s even if inner ones fail. (Closed)

Created:
5 years, 2 months ago by nweiz
Modified:
5 years, 2 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
reviews_dartlang.org, kevmoo
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More robust #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -7 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/backend/group.dart View 1 2 chunks +19 lines, -6 lines 2 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/backend/declarer_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nweiz
5 years, 2 months ago (2015-09-24 20:23:58 UTC) #2
kevmoo
lgtm
5 years, 2 months ago (2015-09-24 20:39:40 UTC) #4
nweiz
I uploaded a change to make this more robust. PTAL
5 years, 2 months ago (2015-09-24 21:05:27 UTC) #5
kevmoo
lgtm LGTM https://codereview.chromium.org/1364893004/diff/20001/lib/src/backend/group.dart File lib/src/backend/group.dart (right): https://codereview.chromium.org/1364893004/diff/20001/lib/src/backend/group.dart#newcode89 lib/src/backend/group.dart:89: /// Runs [body] with special error-handling behavior. ...
5 years, 2 months ago (2015-09-24 21:07:30 UTC) #6
nweiz
https://codereview.chromium.org/1364893004/diff/20001/lib/src/backend/group.dart File lib/src/backend/group.dart (right): https://codereview.chromium.org/1364893004/diff/20001/lib/src/backend/group.dart#newcode89 lib/src/backend/group.dart:89: /// Runs [body] with special error-handling behavior. On 2015/09/24 ...
5 years, 2 months ago (2015-09-24 21:13:07 UTC) #7
nweiz
5 years, 2 months ago (2015-09-24 21:13:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2c25c1ff64059574524413613512a6669fd35c26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698