Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1364813003: Error handling for bad `.analysis_options` files. (Closed)

Created:
5 years, 3 months ago by pquitslund
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -37 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 3 chunks +19 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 3 chunks +55 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 3 months ago (2015-09-23 17:47:13 UTC) #2
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-23 19:55:40 UTC) #3
pquitslund
5 years, 3 months ago (2015-09-23 20:27:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d869088ea389ab5b15455e5de16fc0651273ced5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698