Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1364803003: Use TypeSystem in the 'Extract Method' refactoring. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-23 17:05:25 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-23 17:27:18 UTC) #2
scheglov
5 years, 3 months ago (2015-09-23 17:28:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6899986bfed34b2cfab142397abf7734a9c6f1ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698