Issue 136473003: Speed up typed *List:fromList constructor, by calling setRange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136473003: Speed up typed *List:fromList constructor, by calling setRange. (Closed)

Created:
6 years, 11 months ago by Anders Johnsen

Modified:
6 years, 11 months ago

Reviewers:
Lasse Reichstein Nielsen, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Speed up typed *List:fromList constructor, by calling setRange. BUG= R=lrn@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31909

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -65 lines)			Patch
	M	runtime/lib/typed_data.dart	View		13 chunks	+26 lines, -65 lines	0 comments	Download

Total messages: 4 (0 generated)

Anders Johnsen

This is ~X4 faster when the from-list is a TypedList. However, this is ~X2 slower ...

6 years, 11 months ago (2014-01-16 13:30:44 UTC) #1

srdjan

LGTM. I guess the reason this is faster is because a copy between two typed ...

6 years, 11 months ago (2014-01-16 17:07:28 UTC) #3

Anders Johnsen

6 years, 11 months ago (2014-01-17 08:15:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r31909 (presubmit successful).