Issue 13647005: Disable some tests due to Chrome roll.

Issue 13647005: Disable some tests due to Chrome roll. (Closed)

Created:
7 years, 8 months ago by Anton Muhin

Modified:
7 years, 8 months ago

Reviewers:
vsm, podivilov, Mads Ager (google), blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disable some tests due to Chrome roll. Those test exercise getters which work now with enums in Chromium. TBR=ager@google.com,blois@google.com,podivilov@chromium.org,vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=20926

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	tests/html/canvas_test.dart	View		1 chunk	+2 lines, -0 lines	2 comments	Download
	M	tests/html/xhr_test.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm https://codereview.chromium.org/13647005/diff/1/tests/html/canvas_test.dart File tests/html/canvas_test.dart (right): https://codereview.chromium.org/13647005/diff/1/tests/html/canvas_test.dart#newcode32 tests/html/canvas_test.dart:32: if (false) Would be great to have brackets ...

7 years, 8 months ago (2013-04-04 17:09:10 UTC) #2

Anton Muhin

Committed patchset #1 manually as r20926 (presubmit successful).

7 years, 8 months ago (2013-04-04 17:09:35 UTC) #3

Anton Muhin

https://codereview.chromium.org/13647005/diff/1/tests/html/canvas_test.dart File tests/html/canvas_test.dart (right): https://codereview.chromium.org/13647005/diff/1/tests/html/canvas_test.dart#newcode32 tests/html/canvas_test.dart:32: if (false) On 2013/04/04 17:09:10, blois wrote: > Would ...

7 years, 8 months ago (2013-04-04 17:09:53 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages