Issue 1364583006: Add Element.nameLength getter and specialize it for LibraryElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1364583006: Add Element.nameLength getter and specialize it for LibraryElement. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add Element.nameLength getter and specialize it for LibraryElement. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/24442 Committed: https://github.com/dart-lang/sdk/commit/327412cbadc06398be1aaa86a3bc4a9f4212c671

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -7 lines)			Patch
M	pkg/analyzer/lib/src/generated/element.dart	View	7 chunks	+21 lines, -6 lines	1 comment	Download
M	pkg/analyzer/lib/src/generated/element_handle.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/testing/element_factory.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1364583006/diff/1/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/1364583006/diff/1/pkg/analyzer/lib/src/generated/element.dart#newcode7350 pkg/analyzer/lib/src/generated/element.dart:7350: : super.forNode(name), nameLength = name != null ? ...

5 years, 2 months ago (2015-09-25 20:32:14 UTC) #2

scheglov

5 years, 2 months ago (2015-09-25 20:35:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
327412cbadc06398be1aaa86a3bc4a9f4212c671 (presubmit successful).

Expand Messages | Collapse Messages