Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Issue 1364553002: remove docgen source and targets from build (Closed)

Created:
5 years, 2 months ago by keertip
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4684 lines) Patch
D pkg/docgen/LICENSE View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/docgen/README.md View 1 chunk +0 lines, -140 lines 0 comments Download
D pkg/docgen/bin/docgen.dart View 1 chunk +0 lines, -173 lines 0 comments Download
D pkg/docgen/lib/docgen.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D pkg/docgen/lib/src/exports/dart2js_mirrors.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/docgen/lib/src/exports/libraries.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/docgen/lib/src/exports/mirrors_util.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/docgen/lib/src/exports/source_mirrors.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/docgen/lib/src/generator.dart View 1 chunk +0 lines, -487 lines 0 comments Download
D pkg/docgen/lib/src/io.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D pkg/docgen/lib/src/library_helpers.dart View 1 chunk +0 lines, -220 lines 0 comments Download
D pkg/docgen/lib/src/mdn.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D pkg/docgen/lib/src/models.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/docgen/lib/src/models/annotation.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D pkg/docgen/lib/src/models/class.dart View 1 chunk +0 lines, -245 lines 0 comments Download
D pkg/docgen/lib/src/models/closure.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D pkg/docgen/lib/src/models/doc_gen_type.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D pkg/docgen/lib/src/models/dummy_mirror.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D pkg/docgen/lib/src/models/generic.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D pkg/docgen/lib/src/models/indexable.dart View 1 chunk +0 lines, -221 lines 0 comments Download
D pkg/docgen/lib/src/models/library.dart View 1 chunk +0 lines, -192 lines 0 comments Download
D pkg/docgen/lib/src/models/method.dart View 1 chunk +0 lines, -156 lines 0 comments Download
D pkg/docgen/lib/src/models/mirror_based.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D pkg/docgen/lib/src/models/model_helpers.dart View 1 chunk +0 lines, -443 lines 0 comments Download
D pkg/docgen/lib/src/models/owned_indexable.dart View 1 chunk +0 lines, -70 lines 0 comments Download
D pkg/docgen/lib/src/models/parameter.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D pkg/docgen/lib/src/models/typedef.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D pkg/docgen/lib/src/models/variable.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D pkg/docgen/lib/src/package_helpers.dart View 1 chunk +0 lines, -126 lines 0 comments Download
D pkg/docgen/lib/src/viewer.dart View 1 chunk +0 lines, -201 lines 0 comments Download
D pkg/docgen/pubspec.yaml View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/docgen/test/async_await_test.dart View 1 chunk +0 lines, -150 lines 0 comments Download
D pkg/docgen/test/constant_argument_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D pkg/docgen/test/generate_json_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D pkg/docgen/test/inherited_comments_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D pkg/docgen/test/metadata_test.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D pkg/docgen/test/method_param_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/dottedLibraryName.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/root_lib.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/src/src_lib.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/src/src_lib_part.dart View 1 chunk +0 lines, -3 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/sublib_dir/sub_lib.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/sublib_dir/sub_lib_part.dart View 1 chunk +0 lines, -3 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/test_lib.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/test_lib2.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/test_lib2_bar.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/test_lib2_foo.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/test_lib_bar.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D pkg/docgen/test/multi_library_code/lib/test_lib_foo.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D pkg/docgen/test/multi_library_test.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D pkg/docgen/test/native_extensions_test.dart View 1 chunk +0 lines, -100 lines 0 comments Download
D pkg/docgen/test/only_lib_content_in_pkg_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D pkg/docgen/test/single_library_test.dart View 1 chunk +0 lines, -131 lines 0 comments Download
D pkg/docgen/test/typedef_test.dart View 1 chunk +0 lines, -105 lines 0 comments Download
D pkg/docgen/test/util.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D sdk/bin/dartdocgen View 1 1 chunk +0 lines, -36 lines 0 comments Download
D sdk/bin/dartdocgen.bat View 1 1 chunk +0 lines, -49 lines 0 comments Download
M utils/compiler/compiler.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M utils/compiler/create_snapshot.dart View 4 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
keertip
5 years, 2 months ago (2015-09-22 21:49:06 UTC) #2
Alan Knight
LGTM. Looks good, builds successfully. For thoroughness, there are sdk/bin/dartdocgen[.bat] sdk/bin/docgen[.bat] utils/apidoc/docgen.gyp In fact, I ...
5 years, 2 months ago (2015-09-22 22:00:20 UTC) #3
keertip
On 2015/09/22 22:00:20, Alan Knight wrote: > LGTM. Looks good, builds successfully. > > For ...
5 years, 2 months ago (2015-09-22 22:08:28 UTC) #4
keertip
Committed patchset #2 (id:20001) manually as c775149a5aeb55d573f38d0c636b760ae75c4437 (presubmit successful).
5 years, 2 months ago (2015-09-22 22:10:37 UTC) #5
kevmoo
5 years, 2 months ago (2015-09-22 22:18:40 UTC) #7
Message was sent while issue was closed.
DBC

1) Please add a note to CHANGLOG that this has been removed
2) There still seems to be a few things left

> git grep -I -F -n -e docgen

pkg/pkg.status:18:docgen/test/inherited_comments_test: Fail # issue 22233
pkg/pkg.status:34:docgen/test/*: SkipSlow
pkg/pkg.status:46:docgen/test/*: SkipSlow # Far too slow
pkg/pkg.status:152:docgen/test/*: SkipByDesign # Uses dart:io.
pkg/pkgbuild.status:7:pkg/docgen: Pass, Slow
sdk/bin/docgen:6:echo "The 'docgen' name is deprecated. Prefer 'dartdocgen'
instead."
sdk/bin/docgen:7:dartdocgen "$@"
sdk/bin/docgen.bat:6:echo "The 'docgen.bat' name is deprecated. Prefer
'dartdocgen.bat' instead."
sdk/bin/docgen.bat:7:dartdocgen %*
tools/apps/update_homebrew/bin/update_homebrew.dart:172:   
bin.write_exec_script Dir["#{libexec}/bin/{pub,docgen,dart?*}"]
utils/apidoc/docgen.gyp:18:      'target_name': 'dartdocgen',
utils/apidoc/docgen.gyp:30:          'action_name': 'run_docgen',
utils/apidoc/docgen.gyp:66:            # TODO(alanknight): The docgen name is
deprecated in favour of
utils/apidoc/docgen.gyp:67:            # dartdocgen, and should be removed
eventually.
utils/apidoc/docgen.gyp:68:            '../../sdk/bin/docgen',
utils/apidoc/docgen.gyp:69:            '../../sdk/bin/dartdocgen',
utils/apidoc/docgen.gyp:70:            '../../sdk/bin/docgen.bat',
utils/apidoc/docgen.gyp:71:            '../../sdk/bin/dartdocgen.bat',
utils/apidoc/docgen.gyp:77:           
'<(PRODUCT_DIR)/api_docs/docgen/index.json',
utils/apidoc/docgen.gyp:84:           
'<(PRODUCT_DIR)/dart-sdk/bin/dartdocgen<(script_suffix)',
utils/apidoc/docgen.gyp:85:            '--out=<(PRODUCT_DIR)/api_docs/docgen',
utils/apidoc/docgen.gyp:92:            '--exclude-lib=docgen',
utils/apidoc/docgen.gyp:97:          'message': 'Running dartdocgen:
<(_action)',

Powered by Google App Engine
This is Rietveld 408576698