Issue 136453012: Fix http://dartbug.com/16111

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136453012: Fix http://dartbug.com/16111 (Closed)

Created:
6 years, 11 months ago by Ivan Posva

Modified:
6 years, 11 months ago

Reviewers:
floitsch, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix http://dartbug.com/16111 - Use all bits from the seed value even if passed a Bigint. - Fix out of bounds access in BigintOperations. - Remove obsolete implementation note. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31859

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -4 lines)			Patch
M	runtime/lib/math.cc	View		1 chunk	+17 lines, -2 lines	0 comments	Download
M	runtime/vm/bigint_operations.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/math/random.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/lib/math/random_big_test.dart	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Ivan Posva

Committed patchset #3 manually as r31859 (presubmit successful).

6 years, 11 months ago (2014-01-16 00:02:00 UTC) #4

Message was sent while issue was closed.

LGTM.