Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1364493004: Basic plugin config parsing. (Closed)

Created:
5 years, 3 months ago by pquitslund
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -0 lines) Patch
A pkg/analyzer/lib/src/plugin/plugin_configuration.dart View 1 chunk +119 lines, -0 lines 0 comments Download
A pkg/analyzer/test/src/plugin/plugin_config_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 3 months ago (2015-09-22 22:34:16 UTC) #2
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-22 23:17:01 UTC) #3
pquitslund
5 years, 3 months ago (2015-09-23 00:06:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f4c3b30d8adb8249fa3778f3cddad493aa599587 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698