Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 13641005: Add a sleep function to dart:io (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a sleep function to dart:io The sleep function is a top-level function. R=ager@google.com BUG=https://code.google.com/p/dart/issues/detail?id=9254 Committed: https://code.google.com/p/dart/source/detail?r=20952

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Patch Set 3 : Minor fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -7 lines) Patch
M runtime/bin/io_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/process.cc View 1 3 chunks +11 lines, -2 lines 0 comments Download
M runtime/bin/process_patch.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/utils.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/utils_android.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/utils_linux.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/utils_macos.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/utils_win.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/io_patch.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/io/process.dart View 3 chunks +12 lines, -1 line 0 comments Download
A + tests/standalone/io/sleep_test.dart View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
As you can see I added an all static OS class to runtime/platform. As the ...
7 years, 8 months ago (2013-04-04 16:21:52 UTC) #1
Mads Ager (google)
The code looks good to me. I think I would skip adding this to platform ...
7 years, 8 months ago (2013-04-05 05:51:48 UTC) #2
Søren Gjesse
Moved the OS specific code to runtime/bin/utils_xxx. https://codereview.chromium.org/13641005/diff/1/sdk/lib/io/process.dart File sdk/lib/io/process.dart (right): https://codereview.chromium.org/13641005/diff/1/sdk/lib/io/process.dart#newcode7 sdk/lib/io/process.dart:7: // TODO(ager): ...
7 years, 8 months ago (2013-04-05 09:33:22 UTC) #3
Søren Gjesse
7 years, 8 months ago (2013-04-05 09:35:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r20952 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698