Make the create_sdk build dependent on the dartanalyzer build. This is in

Make the create_sdk build dependent on the dartanalyzer build. This is in
preparation for adding the new analyzer to the sdk.

This CL also removes the upload_sdk task. These uploads are not (and I
believe have never been) used. I can drop this part of the CL if desired.
Committed: https://code.google.com/p/dart/source/detail?r=21096

[ahe, 2013-04-08 08:08:55]

LGTM, but please wait for Dan's approval as well.

https://codereview.chromium.org/13639009/diff/1/dart.gyp
File dart.gyp (left):

https://codereview.chromium.org/13639009/diff/1/dart.gyp#oldcode107
dart.gyp:107: 'tools/upload_sdk.py',
Should you remove this script as well?

https://codereview.chromium.org/13639009/diff/1/dart.gyp
File dart.gyp (right):

https://codereview.chromium.org/13639009/diff/1/dart.gyp#newcode68
dart.gyp:68: 'compiler',
Shouldn't you remove the old analyzer?

[devoncarew, 2013-04-08 09:56:58]

> LGTM, but please wait for Dan's approval as well.

SGTM, but note that Dan is on vacation for another week. Ideally we'd like the
new analyzer in the sdk for M4. Depending on how responsive he is during his
time off, I may ask a surrogate Dan to take a look at this.

https://codereview.chromium.org/13639009/diff/1/dart.gyp
File dart.gyp (left):

https://codereview.chromium.org/13639009/diff/1/dart.gyp#oldcode107
dart.gyp:107: 'tools/upload_sdk.py',
On 2013/04/08 08:08:56, ahe wrote:
> Should you remove this script as well?

I'd like to hold off on that and see what Dan says (I believe he authored that
script).

https://codereview.chromium.org/13639009/diff/1/dart.gyp
File dart.gyp (right):

https://codereview.chromium.org/13639009/diff/1/dart.gyp#newcode68
dart.gyp:68: 'compiler',
On 2013/04/08 08:08:56, ahe wrote:
> Shouldn't you remove the old analyzer?

Our current plan is to have a few weeks of overlap when both analyzers are
available. People are using it as part of a drone.io workflow, and we want to
make the transition as smooth as possible.

[ahe, 2013-04-08 10:47:34]

On 2013/04/08 09:56:58, devoncarew wrote:
> SGTM, but note that Dan is on vacation for another week. Ideally we'd like the
> new analyzer in the sdk for M4. Depending on how responsive he is during his
> time off, I may ask a surrogate Dan to take a look at this.

If you don't get a quick response from Dan, then it would be better to eliminate
removal of upload_sdk from this CL.  I'm not sure what it does, and I'm not sure
who would be a good surrogate.

[devoncarew, 2013-04-08 17:13:49]

> If you don't get a quick response from Dan, then it would be better to
eliminate
> removal of upload_sdk from this CL.  I'm not sure what it does, and I'm not
sure
> who would be a good surrogate.

Good idea; I've removed that part of the CL. It was entirely unrelated in any
case.

[ahe, 2013-04-08 17:20:59]

Still LGTM, of course :-)

[devoncarew, 2013-04-08 17:59:22]

Committed patchset #2 manually as r21096 (presubmit successful).