Issue 13638019: Implement write barrier on ARM.

Issue 13638019: Implement write barrier on ARM. (Closed)

Created:
7 years, 8 months ago by regis

Modified:
7 years, 8 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement write barrier on ARM. Enable StoreIntoObject and DartEntry vm tests. Committed: https://code.google.com/p/dart/source/detail?r=21083

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -19 lines)			Patch
M	runtime/vm/assembler_arm.h	View	1 2	2 chunks	+18 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1 2	1 chunk	+79 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm_test.cc	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_test.cc	View	1 2	2 chunks	+15 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_entry_test.cc	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2	1 chunk	+45 lines, -1 line	0 comments	Download
M	runtime/vm/unit_test.h	View	1 2	1 chunk	+12 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm with comment https://codereview.chromium.org/13638019/diff/4002/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/13638019/diff/4002/runtime/vm/assembler_arm.cc#newcode1353 runtime/vm/assembler_arm.cc:1353: void Assembler::StoreIntoObjectNoBarrier(Register object, The NoBarrier functions ...

7 years, 8 months ago (2013-04-08 15:59:37 UTC) #2

regis

Thanks https://codereview.chromium.org/13638019/diff/4002/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/13638019/diff/4002/runtime/vm/assembler_arm.cc#newcode1353 runtime/vm/assembler_arm.cc:1353: void Assembler::StoreIntoObjectNoBarrier(Register object, On 2013/04/08 15:59:37, zra wrote: ...

7 years, 8 months ago (2013-04-08 16:44:08 UTC) #3

regis

7 years, 8 months ago (2013-04-08 16:44:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r21083 (presubmit successful).

Expand Messages | Collapse Messages