dart2js runtime: Harden objectTypeName.

dart2js runtime: Harden objectTypeName.

1. Avoid crashing on short minified names.
2. Try to find a better name for external JavaScript classes.
3. Try to find a better name for undistingushed native classes.

BUG= http://dartbug.com/24393

This is related to http://dartbug.com/19137

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/5612c202a02e2f39dec8914aa74661d813a92ce5

[sra1, 2015-09-22 03:29:47]

Patchset #1 (id:1) has been deleted

[sra1, 2015-09-22 06:12:54]

sra@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-09-22 16:51:23]

lgtm, just minor comments below

https://codereview.chromium.org/1362553002/diff/20001/sdk/lib/_internal/js_ru...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://codereview.chromium.org/1362553002/diff/20001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:876: // We get here via the
UnknownJavaScriptObject test for JavaScript objects
We get here ... The object's
   =>
If we get here ... Then, the object's
^^                 ^^^^

https://codereview.chromium.org/1362553002/diff/20001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:879: // We get here the
Interceptor test for Native classes that are declared
We get here the ... The native
  =>
If we get here via the  ... Then, the native
^^             ^^^          ^^^^

https://codereview.chromium.org/1362553002/diff/20001/tests/compiler/dart2js_...
File tests/compiler/dart2js_native/error_safeToString_test.dart (right):

https://codereview.chromium.org/1362553002/diff/20001/tests/compiler/dart2js_...
tests/compiler/dart2js_native/error_safeToString_test.dart:45: x.constructor =
null;  // Foils constructor lookup.
Foils => Fails? (same below)

https://codereview.chromium.org/1362553002/diff/20001/tests/compiler/dart2js_...
tests/compiler/dart2js_native/error_safeToString_test.dart:116: print('A  $x 
${Error.safeToString(x)}');
do you need to keep the prints in the test? or where they mainly for debugging?

https://codereview.chromium.org/1362553002/diff/20001/tests/compiler/dart2js_...
tests/compiler/dart2js_native/error_safeToString_test.dart:145:
Expect.notEquals("Instance of 'PP'", Error.safeToString(x));
Do we prevent minification from picking names we've seen in @Native? (any chance
that the minifier picks PP for the minified name of Purple?)

https://codereview.chromium.org/1362553002/diff/20001/tests/compiler/dart2js_...
tests/compiler/dart2js_native/error_safeToString_test.dart:156: // The toString
calls (interpolation) force Rascal to be distinguished.
maybe also make a note here that this is because Rascal overrides toString?

[sra1, 2015-09-22 21:46:36]

Committed patchset #4 (id:80001) manually as
5612c202a02e2f39dec8914aa74661d813a92ce5 (presubmit successful).

[sra1, 2015-09-23 03:58:21]

https://chromiumcodereview.appspot.com/1362553002/diff/20001/sdk/lib/_interna...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/1362553002/diff/20001/sdk/lib/_interna...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:876: // We get here via the
UnknownJavaScriptObject test for JavaScript objects
On 2015/09/22 16:51:23, Siggi Cherem (dart-lang) wrote:
> We get here ... The object's
>    =>
> If we get here ... Then, the object's
> ^^                 ^^^^

Acknowledged.

https://chromiumcodereview.appspot.com/1362553002/diff/20001/sdk/lib/_interna...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:879: // We get here the
Interceptor test for Native classes that are declared
On 2015/09/22 16:51:23, Siggi Cherem (dart-lang) wrote:
> We get here the ... The native
>   =>
> If we get here via the  ... Then, the native
> ^^             ^^^          ^^^^

Acknowledged.

https://chromiumcodereview.appspot.com/1362553002/diff/20001/tests/compiler/d...
File tests/compiler/dart2js_native/error_safeToString_test.dart (right):

https://chromiumcodereview.appspot.com/1362553002/diff/20001/tests/compiler/d...
tests/compiler/dart2js_native/error_safeToString_test.dart:45: x.constructor =
null;  // Foils constructor lookup.
On 2015/09/22 16:51:23, Siggi Cherem (dart-lang) wrote:
> Foils => Fails? (same below)

To foil is to prevent from succeeding, "a brave policewoman foiled the armed
robbery".

https://chromiumcodereview.appspot.com/1362553002/diff/20001/tests/compiler/d...
tests/compiler/dart2js_native/error_safeToString_test.dart:116: print('A  $x 
${Error.safeToString(x)}');
On 2015/09/22 16:51:23, Siggi Cherem (dart-lang) wrote:
> do you need to keep the prints in the test? or where they mainly for
debugging?

I'll remove them.

https://chromiumcodereview.appspot.com/1362553002/diff/20001/tests/compiler/d...
tests/compiler/dart2js_native/error_safeToString_test.dart:145:
Expect.notEquals("Instance of 'PP'", Error.safeToString(x));
On 2015/09/22 16:51:23, Siggi Cherem (dart-lang) wrote:
> Do we prevent minification from picking names we've seen in @Native? (any
chance
> that the minifier picks PP for the minified name of Purple?)

Good point.  Changed to PPPP.

https://chromiumcodereview.appspot.com/1362553002/diff/20001/tests/compiler/d...
tests/compiler/dart2js_native/error_safeToString_test.dart:156: // The toString
calls (interpolation) force Rascal to be distinguished.
On 2015/09/22 16:51:23, Siggi Cherem (dart-lang) wrote:
> maybe also make a note here that this is because Rascal overrides toString?

Done.