Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1362503002: Add global timeline stream overrides (Closed)

Created:
5 years, 3 months ago by Cutch
Modified:
5 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add global timeline stream overrides - Needed for the mojo TraceProvider implementation R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/860b9140a7942f81542a2d10d2bb38a1c986bd2d

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -20 lines) Patch
M runtime/include/dart_tools_api.h View 1 2 chunks +17 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/timeline.h View 1 4 chunks +32 lines, -12 lines 0 comments Download
M runtime/vm/timeline.cc View 1 3 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 3 months ago (2015-09-21 21:04:39 UTC) #2
rmacnak
lgtm w/c https://codereview.chromium.org/1362503002/diff/1/runtime/include/dart_tools_api.h File runtime/include/dart_tools_api.h (right): https://codereview.chromium.org/1362503002/diff/1/runtime/include/dart_tools_api.h#newcode923 runtime/include/dart_tools_api.h:923: DART_EXPORT void Dart_GlobalTimelineSetRecordedStreams(int64_t stream_mask); mention that a ...
5 years, 3 months ago (2015-09-21 21:12:36 UTC) #3
Cutch
https://codereview.chromium.org/1362503002/diff/1/runtime/include/dart_tools_api.h File runtime/include/dart_tools_api.h (right): https://codereview.chromium.org/1362503002/diff/1/runtime/include/dart_tools_api.h#newcode923 runtime/include/dart_tools_api.h:923: DART_EXPORT void Dart_GlobalTimelineSetRecordedStreams(int64_t stream_mask); On 2015/09/21 21:12:35, rmacnak wrote: ...
5 years, 3 months ago (2015-09-21 21:19:55 UTC) #4
Cutch
5 years, 3 months ago (2015-09-21 21:24:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
860b9140a7942f81542a2d10d2bb38a1c986bd2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698