Issue 13625003: Make EventTransformerStream's subscription not send events after cancel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13625003: Make EventTransformerStream's subscription not send events after cancel. (Closed)

Created:
7 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make EventTransformerStream's subscription not send events after cancel. Also make Stream.firstm, Stream.single and Stream.elementAt cancel their subscription before completing the future, instead of after. BUG=http://dartbug.com/7964 Committed: https://code.google.com/p/dart/source/detail?r=21140

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -9 lines)			Patch
	M	sdk/lib/async/stream.dart	View		7 chunks	+14 lines, -9 lines	0 comments	Download
	A	tests/lib/async/first_regression_test.dart	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. I think I have seen similar issues with stream_periodic4_test. See http://dartbug.com/9619 The error on ...

7 years, 8 months ago (2013-04-05 15:15:08 UTC) #2

Lasse Reichstein Nielsen

7 years, 8 months ago (2013-04-09 09:26:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21140 (presubmit successful).

Expand Messages | Collapse Messages