Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1362353003: suggest argument name completions for annotations - fixes #24296 and fixes #24259 (Closed)

Created:
5 years, 2 months ago by danrubel
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

suggest argument name completions for annotations - fixes #24296 and fixes #24259 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a24ae72e74a4b2783b30ddb02d415e95fb11950f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart View 1 chunk +13 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/services/completion/arglist_contributor_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 2 months ago (2015-09-25 21:43:07 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-09-25 21:54:01 UTC) #3
danrubel
5 years, 2 months ago (2015-10-02 16:54:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a24ae72e74a4b2783b30ddb02d415e95fb11950f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698