Issue 136223002: Generate names for anonymous Java classes using enclosing classes and members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136223002: Generate names for anonymous Java classes using enclosing classes and members. (Closed)

Created:
6 years, 11 months ago by scheglov

Modified:
6 years, 11 months ago

Reviewers:
devoncarew, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Generate names for anonymous Java classes using enclosing classes and members. R=brianwilkerson@google.com, devoncarew@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31741

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+210 lines, -97 lines)			Patch
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java	View	3 chunks	+64 lines, -0 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java	View	3 chunks	+11 lines, -2 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java	View	8 chunks	+58 lines, -18 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/ast.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/html.dart	View	6 chunks	+9 lines, -9 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/instrumentation.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	16 chunks	+24 lines, -24 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source.dart	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source_io.dart	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/generated/ast_test.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/generated/element_test.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	5 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

6 years, 11 months ago (2014-01-13 16:00:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r31741 (presubmit successful).

Expand Messages | Collapse Messages